r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

Depends, could you show the use case for this? Right now I don't see why people would want this.

In my case, I want to pass a key for Warden so that my templates will not throw errors.

But more generally, I was rather surprised that it converted my keys to nil instead of just passing them through. I would imagine there are an infinite number of ways that view templates might rely on the environment outside of those predefined keys in the RACK_KEY_TRANSLATION hash.

I think a better way to go about it might be how it handles the values though:

https://github.com/codeodor/rails/blob/bfc6fbb0004694f94a3679176c4a3e58f3ca8a97/actionpack/lib/action_controller/renderer.rb#L108

More specifically, if I do something like this:

warden_manager = "set up warden"
SomeController.renderer.new(warden: warden_manager).render

Then in the template, if we check request.env['warden'] it is currently nil. If instead we check request.env[nil] it will be "set up warden".

This pull request fixes it so that the renderer will not produce the extra nil key, and to where request.env['warden'] will equal "set up warden"

Thanks @rafaelfranca, and done!

Thanks @codeodor! 😄